[fortinet_fortigate] add hostname parsing for syslog #11678
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
andrewkroh
added
Integration:fortinet_fortigate
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
andrewkroh
added
bugfix
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Nacon96
commented
Nov 11, 2024
taylor-swanson
requested changes
Nov 12, 2024
There was a problem hiding this comment.
In case I wasn't clear, the changes I requested are ones I'm requiring.
- For how we use semver, any additional fields added require at least a
minorchange to versioning. Patch versions are reserved for bugfixes/enhancements that don't alter the structure of documents, among other things. - We don't need to set fields from a grok only to not use them and only remove them later. This just adds unnecessary actions to the pipeline.
…st_pipeline/default.yml Co-authored-by: Taylor Swanson <[email protected]>
Co-authored-by: Taylor Swanson <[email protected]>
…st_pipeline/default.yml Co-authored-by: Taylor Swanson <[email protected]>
…st_pipeline/default.yml Co-authored-by: Taylor Swanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The current parser is not processing the hostname field of syslog messages, so in some cases, the
observer.namefield remains empty.Checklist
changelog.ymlfile.