Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5854) [helm]: implement support for defining image pull secrets #5881

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 30, 2024

What does this PR do?

This PR that adds support for defining pullImageSecrets support in the chart

Why is it important?

Users mights need to deploy an agent image from a private repository

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

How to test this PR locally

mage integration:kubernetesMatrix

This is an automatic backport of pull request #5854 done by [Mergify](https://mergify.com).

* feat: implement support for defining image pull secrets

* doc: add imagePullSecrets in kubernetes default example

(cherry picked from commit 053b320)

# Conflicts:
#	deploy/helm/elastic-agent/values.yaml
@mergify mergify bot requested a review from a team as a code owner October 30, 2024 10:40
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 30, 2024
@mergify mergify bot requested review from kaanyalti and andrzej-stencel and removed request for a team October 30, 2024 10:40
Copy link
Contributor Author

mergify bot commented Oct 30, 2024

Cherry-pick of 053b320 has failed:

On branch mergify/bp/8.x/pr-5854
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit 053b3200fc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   deploy/helm/elastic-agent/README.md
	modified:   deploy/helm/elastic-agent/examples/kubernetes-default/README.md
	modified:   deploy/helm/elastic-agent/templates/agent/eck/_pod_template.tpl
	modified:   deploy/helm/elastic-agent/templates/agent/k8s/_pod_template.tpl
	modified:   deploy/helm/elastic-agent/values.schema.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deploy/helm/elastic-agent/values.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant