-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm]: integration config for scheduler and controller-manager conditions and containers logs #5853
[helm]: integration config for scheduler and controller-manager conditions and containers logs #5853
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
id: kubernetes-container-logs-${kubernetes.pod.name}-${kubernetes.container.id} | ||
parsers: | ||
- container: | ||
format: auto | ||
stream: all | ||
paths: | ||
- /var/log/containers/*${kubernetes.container.id}.log | ||
processors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was these sections removed because it caused the events to not match the integration?
If we do want the container logs to be identical, shouldn't we simply copy the standalone config from here:
|
@swiatekm not entirely sure why the standalone agent manifest doesn't include them but this is what Kibana generates when you try to install the kubernetes integration which includes default values (snippet regards container logs)
So I think that it should not be a copy paste from there?! @blakerouse thank you for catching that, I was experimenting with some config until I realised I need |
cd1fcc4
to
0c1879a
Compare
Quality Gate passedIssues Measures |
What does this PR do?
I was testing k8s standalone elastic-agent using the plain k8s manifest under
deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml
but I also tried to get the same results with the elastic-agent helm chart and I tried to replicate the produced data with the elastic-agent helm chart. This effort uncovered some yaml format issues and some inconsistencies for container logs which this PR handlesWhy is it important?
Because it fixes bugs 🙂
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
N/A
How to test this PR locally
Related issues