Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main][Automation] Update versions #5820

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

These files are used for picking the starting (pre-upgrade) or ending (post-upgrade) agent versions in upgrade integration tests.

The content is based on responses from https://www.elastic.co/api/product_versions and https://snapshots.elastic.co

The current update is generated based on the following requirements:

Package version: 9.0.0

{
  "UpgradeToVersion": "9.0.0",
  "CurrentMajors": 1,
  "PreviousMajors": 1,
  "PreviousMinors": 2,
  "SnapshotBranches": [
    "8.15",
    "8.x",
    "7.17"
  ]
}

These files are used for picking the starting (pre-upgrade) or ending (post-upgrade) agent versions in upgrade integration tests.

The content is based on responses from https://www.elastic.co/api/product_versions and https://snapshots.elastic.co

The current update is generated based on the following requirements:

Package version: 9.0.0

```json
{
  "UpgradeToVersion": "9.0.0",
  "CurrentMajors": 1,
  "PreviousMajors": 1,
  "PreviousMinors": 2,
  "SnapshotBranches": [
    "8.15",
    "8.x",
    "7.17"
  ]
}
```
@github-actions github-actions bot requested a review from a team as a code owner October 18, 2024 00:30
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team backport-skip skip-changelog update-versions Updates to the agent versions file labels Oct 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@rdner rdner enabled auto-merge (squash) October 18, 2024 20:50
@ycombinator
Copy link
Contributor

@jsoriano @mrodm Most of the tests failing in CI on this PR have this error:

error installing fleet package: [system] package not installed or found in registry

Could it be because the version of the system package specified in these tests, 1.53.1, is too old? I know there was recently some work you did to relax the restriction on installing this package on 9.0.0.

@jsoriano
Copy link
Member

What configuration has the kibana instance used for these tests? It should have this option:

xpack.fleet.internal.registry.kibanaVersionCheckEnabled: false

@ycombinator
Copy link
Contributor

ycombinator commented Oct 22, 2024

Thanks @jsoriano. Testing this change on this PR via 5430290.

@rdner
Copy link
Member

rdner commented Oct 23, 2024

@ycombinator there are still some issues with running APM.

@ycombinator
Copy link
Contributor

Thanks for the ping @rdner. Looks like the test calls a Kibana API, GET /internal/apm/fleet/agents to get APM connection configuration from Kibana. This should include the APM server URL but looks like that's coming back as empty. Checking manually on a 9.0.0-SNAPSHOT deployment in ESS CFT to see what this API call returns...

@ycombinator
Copy link
Contributor

ycombinator commented Oct 23, 2024

Checking manually on a 9.0.0-SNAPSHOT deployment in ESS CFT to see what this API call returns...

Ruh roh:

{
  "statusCode":400,
  "error":"Bad Request",
  "message":"uri [/internal/apm/fleet/agents] with method [get] exists but is not available with the current configuration"
}

The same API call does work with an 8.16.0-SNAPSHOT deployment so this appears to be a breaking change in 9.0.0:

{
  "cloudStandaloneSetup":{
    "apmServerUrl":"https://d7f64754cf774113b9d196a5fd20ce2d.apm.us-west2.gcp.elastic-cloud.com:443",
    "secretToken":"XXXXXXXXXX"
  },
  "isFleetEnabled":true,
  "fleetAgents":[
    {
      "id":"policy-elastic-agent-on-cloud",
      "name":"Elastic Cloud agent policy",
      "apmServerUrl":"https://d7f64754cf774113b9d196a5fd20ce2d.apm.us-west2.gcp.elastic-cloud.com:443",
      "secretToken":"XXXXXXXXXX"
    }
  ]
}

I'll follow up with the APM Server team on how to proceed here.

@ycombinator
Copy link
Contributor

@inge4pres helped me out — thank you! — and I am trying out his suggestion in 2af748b.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@rdner rdner merged commit 3fda88b into main Oct 23, 2024
14 checks passed
@rdner rdner deleted the update-agent-versions-11395162283 branch October 23, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team update-versions Updates to the agent versions file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants