[8.x](backport #5699) Only watch metadata for ReplicaSets in K8s provider #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
MichaelKatsoulis and
constanca-m
and removed request for
a team
mergify
bot
requested review from
blakerouse and
swiatekm
and removed request for
a team
MichaelKatsoulis
approved these changes
Oct 8, 2024
swiatekm
approved these changes
Oct 8, 2024
|
Blocked by #5702 |
Use a metadata informer for ReplicaSets. Use a transform function to drop all data except for the owner references, which we need to find the Deployment name. (cherry picked from commit 05f9e81)
swiatekm
force-pushed
the
mergify/bp/8.x/pr-5699
branch
from
a3fa404
to
dff7cae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use a metadata watcher for ReplicaSets in the K8s provider. The only data we need from ReplicaSets are their name and OwnerReferences, which are used to connect Pods to Deployments and DaemonSets.
Why is it important?
This significantly reduces both memory used to store ReplicaSet data, and temporary allocations to process update events from the API Server. See the linked issue for more detailed information.
Checklist
./changelog/fragmentsusing the changelog toolHow to test this PR locally
Showing that the change doesn't cause a regression requires starting agent in K8s and enabling deployment metadata in the K8s provider, and then using it in a templated input definition - this is simplest with filebeat.
Demonstrating the memory consumption improvement is more involved - you need to create a significant amount of ReplicaSets in the cluster. I saw a noticable difference at ~7500, see #5623 for more details.
Related issues
This is an automatic backport of pull request #5699 done by [Mergify](https://mergify.com).