Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7](backport #4483) Update elastic-agent-logging.md with right calculation details for disk sizing #5723

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

While researching for a case I noticed that there might have been a typo mistake here where the calculation of the default disk size required for the Elastic Agent's log files was explained.

What does this PR do?

  • The calculation of the amount of disk had a small mistake on line 70.
  • It should be:
(20Mb x 7 + 10Mb x 7 = 210Mb)

Why is it important?

Right calculation of the defaults would be necessary to set the right expectations.


This is an automatic backport of pull request #4483 done by Mergify.

The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
@mergify mergify bot added the backport label Oct 7, 2024
@mergify mergify bot requested a review from a team as a code owner October 7, 2024 16:49
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Oct 7, 2024
@mergify mergify bot requested review from michel-laterman and swiatekm and removed request for a team October 7, 2024 16:49
Copy link
Contributor Author

mergify bot commented Oct 7, 2024

Cherry-pick of 1eb5e12 has failed:

On branch mergify/bp/8.7/pr-4483
Your branch is up to date with 'origin/8.7'.

You are currently cherry-picking commit 1eb5e12dbc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/elastic-agent-logging.md

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants