-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert forcing Agent version to be 8.16.0 #5617
Conversation
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
|
|
10d59b7
to
9d0b751
Compare
@michel-laterman it looks there is still an issue while communicating with fleet-server which is:
Do you know where this could be coming from? This happened on the extended runtime leak tests |
The issue seems to be that we are still creating an
|
.package-version
Outdated
9.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This normally is handled by the automation ---> #5588
since it would be a chicken and egg problem I guess we can update .package.version
here and close the other PR once we merge this
Now a bunch of tests are failing CI with:
I'm working on a fix for this issue and will add it to this PR. |
8ac8a12
to
9c87d83
Compare
This happens because in our test where we look for a previous minor (still not convinced it is really needed) we don't handle the case of a new major with minor and patch version set to 0. This would be a good opportunity to get rid of GetPreviousMinor() if possible |
2a5cd69
to
89b7612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as CI passes 😄
This pull request is now in conflicts. Could you fix it? 🙏
|
1 similar comment
This pull request is now in conflicts. Could you fix it? 🙏
|
c2476ba
to
b3c6de2
Compare
b3c6de2
to
37c453f
Compare
Quality Gate passedIssues Measures |
* Revert forcing Agent version to be 8.16.0 * Update version in .package-version file * Return latest minor of previous version if current version is first release of a new major * Remove debugging statement (cherry picked from commit a5de320) # Conflicts: # .buildkite/scripts/steps/integration-package.sh # .buildkite/scripts/steps/integration_tests.sh # .buildkite/scripts/steps/k8s-extended-tests.sh
This PR reverts the changes made in #5565 as it is now possible to create
9.0.0-SNAPSHOT
deployments on ESS prod in the CFT region.Resolves #5567