Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove 7.17.X from the upgrade version list until integration tests are stable again #5450

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

pchila
Copy link
Member

@pchila pchila commented Sep 6, 2024

What does this PR do?

Temporarily remove 7.17 versions from elastic-agent integration tests until tests are green again

Why is it important?

To allow #5379 to be merged in a timely manner

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila requested a review from a team as a code owner September 6, 2024 10:06
@pchila pchila requested review from andrzej-stencel and swiatekm and removed request for a team September 6, 2024 10:06
@mergify mergify bot assigned pchila Sep 6, 2024
@pchila pchila requested review from ycombinator, cmacknz, jlind23 and pierrehilbert and removed request for andrzej-stencel and swiatekm September 6, 2024 10:08
@pchila pchila added skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Sep 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this merges, create a PR reverting it since 8.15.2-SNAPSHOT existing should fix it and/or the 7.17 fix will fix it for 7.17.24-SNAPSHOT.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ycombinator
Copy link
Contributor

Serverless integration tests are failing on TestLogIngestionFleetManaged/Monitoring_logs_are_shipped. I just reopened #3741 to try and fix it again.

@ycombinator
Copy link
Contributor

Integration tests are failing on TestDebLogIngestFleetManaged/Monitoring_logs_are_shipped.

@ycombinator
Copy link
Contributor

ycombinator commented Sep 6, 2024

[EDIT] Neither failure is related to the changes in this PR and they are also failing on the 8.15 branch right now. We need this PR to be merged to unblock the 8.15.1 so I'm going to force merge this PR.

@ycombinator ycombinator merged commit 83800f0 into elastic:8.15 Sep 6, 2024
10 of 13 checks passed
pchila added a commit to pchila/elastic-agent that referenced this pull request Sep 9, 2024
… integration tests are stable again (elastic#5450)"

This reverts commit 83800f0.
@pchila pchila mentioned this pull request Sep 9, 2024
7 tasks
@pchila
Copy link
Member Author

pchila commented Sep 9, 2024

Once this merges, create a PR reverting it since 8.15.2-SNAPSHOT existing should fix it and/or the 7.17 fix will fix it for 7.17.24-SNAPSHOT.

Revert PR is #5471

pchila added a commit that referenced this pull request Sep 9, 2024
… integration tests are stable again (#5450)" (#5471)

This reverts commit 83800f0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants