Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support flattened data_stream.* fields" #3743

Closed
wants to merge 1 commit into from

Conversation

belimawr
Copy link
Contributor

Reverts #3465 because it seems to be breaking some integration tests: #3741

Copy link
Contributor

mergify bot commented Nov 10, 2023

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@cmacknz
Copy link
Member

cmacknz commented Nov 10, 2023

buildkite test it

@cmacknz
Copy link
Member

cmacknz commented Nov 10, 2023

The previous version of the test failed with:

Failed to uninstall agent  [9s] Error: error uninstalling agent: failed to remove installation directory (C:\\Program Files\\Elastic\\Agent): timed out while removing \"C:\\\\Program Files\\\\Elastic\\\\Agent\". Last error: remove C:\\Program Files\\Elastic\\Agent\\data\\elastic-agent-3238b7\\elastic-agent.exe: Access is denied.\nFor help, please see our troubleshooting guide at https://www.elastic.co/guide/en/fleet/8.12/fleet-troubleshooting.html\n

This is an unrelated problem.

@cmacknz
Copy link
Member

cmacknz commented Nov 10, 2023

Reverting this reveals a different failure:

        Elastic Agent has been successfully installed.
    monitoring_logs_test.go:70: created policy: 905338ce-b6d3-4920-ab57-384c59eddb36
    fixture.go:505: >> running binary with: [/opt/Elastic/Agent/elastic-agent status --output json]
    monitoring_logs_test.go:77: 
        	Error Trace:	/home/ubuntu/agent/testing/integration/monitoring_logs_test.go:77
        	Error:      	Received unexpected error:
        	            	error unmarshaling response: error unmarshalling JSON for string 'null': strconv.ParseInt: parsing "null": invalid syntax
        	Test:       	TestMonitoringLogsShipped
    fixture_install.go:127: [test TestMonitoringLogsShipped] Inside fixture cleanup function
    fixture_install.go:142: collecting diagnostics; test failed
    fixture.go:505: >> running binary with: [/opt/Elastic/Agent/elastic-agent diagnostics -f /home/ubuntu/agent/build/diagnostics/TestMonitoringLogsShipped-diagnostics-2023-11-10T20:13:50Z.zip]
    fixture.go:505: >> running binary with: [/opt/Elastic/Agent/elastic-agent uninstall --force]
--- FAIL: TestMonitoringLogsShipped (56.95s)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-13T12:57:09.639+0000

  • Duration: 62 min 23 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pchila
Copy link
Member

pchila commented Nov 13, 2023

/test

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

mergify bot commented Nov 14, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b revert-3465-flattened-datastreams upstream/revert-3465-flattened-datastreams
git merge upstream/main
git push upstream revert-3465-flattened-datastreams

@belimawr
Copy link
Contributor Author

The fix for the root cause that triggered this revert is here: #3765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants