Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint package version on tests #3668

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

belimawr
Copy link
Contributor

What does this PR do?

Update the endpoint package version for integration tests, some tests were failing because the old version was not found.

Why is it important?

Fixes: #3524, at least until newer versions are released.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in ./changelog/fragments using the changelog tool
    - [ ] I have added an integration test or an E2E test

## Author's Checklist

How to test this PR locally

Run the integration tests: mage integration:test

## Related issues
## Use cases
## Screenshots
## Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?

@belimawr belimawr requested a review from a team as a code owner October 27, 2023 10:58
@belimawr belimawr added the Team:Elastic-Agent Label for the Agent team label Oct 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2023

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-03T10:51:09.643+0000

  • Duration: 13 min 27 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 27, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.824% (84/85) 👍
Files 66.885% (204/305) 👍
Classes 66.011% (369/559) 👍
Methods 53.062% (1161/2188) 👍
Lines 39.431% (13698/34739) 👍 0.035
Conditionals 100.0% (0/0) 💚

@belimawr
Copy link
Contributor Author

belimawr commented Nov 2, 2023

Rebased onto main.

Update the endpoint package version for integration tests, some tests
were failing because the old version was not found.
@belimawr
Copy link
Contributor Author

belimawr commented Nov 3, 2023

/test

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@belimawr belimawr merged commit ba4b78c into elastic:main Nov 3, 2023
12 checks passed
@belimawr belimawr deleted the fix-endpoint-tests branch November 3, 2023 15:04
@cmacknz cmacknz added the backport-v8.11.0 Automated backport with mergify label Nov 3, 2023
@cmacknz
Copy link
Member

cmacknz commented Nov 3, 2023

We should backport this as this should be affecting every active branch.

mergify bot pushed a commit that referenced this pull request Nov 3, 2023
Update the endpoint package version for integration tests, some tests
were failing because the old version was not found.

(cherry picked from commit ba4b78c)
pierrehilbert added a commit that referenced this pull request Dec 4, 2023
Update the endpoint package version for integration tests, some tests
were failing because the old version was not found.

(cherry picked from commit ba4b78c)

Co-authored-by: Tiago Queiroz <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip backport-v8.11.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
5 participants