Disable exposing metrics server on all interfaces #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
enhancement
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
SonarQube Quality Gate
|
|
ci failing on processing failed results 🤦 |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
I re-ran the processing step that seems to be okay this time |
michalpristas
changed the title
AndersonQ
approved these changes
Oct 27, 2023
| http: | ||
| enabled: true | ||
| host: " "`, DefaultHost}, | ||
| {"default", `enabled: true |
There was a problem hiding this comment.
[Suggestion]
Suggested change
| {"default", `enabled: true | |
| {"default host", `enabled: true |
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
This PR disables option to configure agent in a way that it will expose monitoring agent on all interfaces. Empty value for agent.monitoring.http.host is now disabled and is replaced by localhost Agents upgraded from <8.5 do have empty host due to change in defaults in 8.5. These agents are exposing metrics endpoint on all interfaces not on purpose. Guard is implemented at the time of configuration unpacking and at the time of server creation to minimize future misbehavior with possible code changes (cherry picked from commit 2afea75)
michalpristas
added a commit
that referenced
this pull request
Oct 30, 2023
This PR disables option to configure agent in a way that it will expose monitoring agent on all interfaces. Empty value for agent.monitoring.http.host is now disabled and is replaced by localhost Agents upgraded from <8.5 do have empty host due to change in defaults in 8.5. These agents are exposing metrics endpoint on all interfaces not on purpose. Guard is implemented at the time of configuration unpacking and at the time of server creation to minimize future misbehavior with possible code changes (cherry picked from commit 2afea75) Co-authored-by: Michal Pristas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables option to configure agent in a way that it will expose monitoring agent on all interfaces.
Empty value for
agent.monitoring.http.hostis now disabled and is replaced by localhostAgents upgraded from <8.5 do have empty host due to change in defaults in 8.5. These agents are exposing metrics endpoint on all interfaces not on purpose.
Guard is implemented at the time of configuration unpacking and at the time of server creation to minimize future misbehavior with possible code changes
Fixes: #2509