-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust timeouts so tests have better chance of succeeding #3549
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
🌐 Coverage report
|
The buildkite failure is unrelated:
This failure is being addressed in #3207 |
@@ -335,7 +335,6 @@ func TestCoordinatorShutdownErrorOneResponse(t *testing.T) { | |||
} | |||
|
|||
func TestCoordinatorShutdownErrorAllResponses(t *testing.T) { | |||
CoordinatorShutdownTimeout = time.Millisecond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this make the value of the shutdown timeout dependent on the order in which tests are executed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, I added these back and set to what the default is during normal operations
SonarQube Quality Gate 0 Bugs No Coverage information |
* adjust timeouts so tests have better chance of succeeding (cherry picked from commit dcf2263)
) * adjust timeouts so tests have better chance of succeeding (cherry picked from commit dcf2263) Co-authored-by: Lee E Hinman <[email protected]>
What does this PR do?
adjust timeouts on the Coordinator tests so they have a better chance of succeeding in CI
Why is it important?
Flaky tests in CI
Checklist
./changelog/fragments
using the changelog toolAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself