Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.10](backport #3383) Implement basic version negotiation with Fleet Server #3405

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[8.10](backport #3383) Implement basic version negotiation with Fleet Server #3405

merged 1 commit into from
Sep 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 12, 2023

This is an automatic backport of pull request #3383 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner September 12, 2023 18:33
@mergify mergify bot requested review from blakerouse and pchila and removed request for a team September 12, 2023 18:33
@mergify mergify bot added the backport label Sep 12, 2023
@mergify mergify bot assigned pchila Sep 12, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 12, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-19T14:13:19.942+0000

  • Duration: 30 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 6267
Skipped 57
Total 6324

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 12, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.832% (194/286) 👍 0.113
Classes 66.48% (357/537) 👍 0.188
Methods 53.238% (1118/2100) 👍 0.159
Lines 38.701% (12714/32852) 👍 0.063
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pchila
Copy link
Member

pchila commented Sep 13, 2023

/test

@pchila
Copy link
Member

pchila commented Sep 14, 2023

@Mergifyio rebase

@pchila
Implement basic version negotiation with Fleet Server (#3383)
96f7916 
* Initial implementation of elastic api version in roundtrip and fleet client
* signal Fleet warning on elastic-agent status

(cherry picked from commit fe0d427)
@mergify
Copy link
Contributor Author

mergify bot commented Sep 14, 2023

rebase

✅ Branch has been successfully rebased

@mergify
Copy link
Contributor Author

mergify bot commented Sep 18, 2023

This pull request has not been merged yet. Could you please review and merge it @pchila? 🙏

@pchila
Copy link
Member

pchila commented Sep 18, 2023

buildkite test this

1 similar comment
@pchila
Copy link
Member

pchila commented Sep 18, 2023

buildkite test this

@pierrehilbert
Copy link
Contributor

With the version bump, we will have to wait for 8.10.2 builds to be available before running tests again

@pchila
Copy link
Member

pchila commented Sep 19, 2023

/test

@mergify
Copy link
Contributor Author

mergify bot commented Sep 25, 2023

This pull request has not been merged yet. Could you please review and merge it @pchila? 🙏

@pchila
Copy link
Member

pchila commented Sep 25, 2023

buildkite test this

@pchila pchila merged commit 6809c03 into 8.10 Sep 25, 2023
20 of 23 checks passed
@pchila pchila deleted the mergify/bp/8.10/pr-3383 branch September 25, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@pchila pchila

Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @pchila @pierrehilbert