Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.10](backport #3166) [Upgrade Watcher][Crash Checker] Consider Agent process as crashed if its PID remains 0 #3386

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[8.10](backport #3166) [Upgrade Watcher][Crash Checker] Consider Agent process as crashed if its PID remains 0 #3386

merged 1 commit into from
Sep 14, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 8, 2023

This is an automatic backport of pull request #3166 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner September 8, 2023 16:00
@mergify mergify bot requested review from blakerouse and pchila and removed request for a team September 8, 2023 16:00
@mergify mergify bot added the backport label Sep 8, 2023
@ycombinator ycombinator enabled auto-merge (squash) September 8, 2023 16:00
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 8, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T15:34:07.588+0000

  • Duration: 26 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 6253
Skipped 55
Total 6308

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 8, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.719% (193/285) 👍
Classes 66.292% (354/534) 👍
Methods 53.079% (1112/2095) 👍 0.09
Lines 38.641% (12680/32815) 👍 0.091
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor Author

mergify bot commented Sep 11, 2023

This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Sep 14, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.10/pr-3166 upstream/mergify/bp/8.10/pr-3166
git merge upstream/8.10
git push upstream mergify/bp/8.10/pr-3166

@ycombinator
[Upgrade Watcher][Crash Checker] Consider Agent process as crashed if…
5d6caf3 
… its PID remains 0 (#3166)

* Refactoring: extract helper method

* Add check for PID remaining 0

* Update + add tests

* Fix typo

* Add CHANGELOG fragment

* Better error messages

* Bump up Agent version + cause error on start

* Better logging for debugging

* More logging for debugging

* Trying secondary restart via service manager

* Add FIXME comments for testing-only changes

* Fix compile errors

* Update testing version

* Implement restart for upstart service manager

* Include service provider name in error

* Implement restart for sysv and darwin

* Implement Restart for Windows

* Remove all Restart() implementations

* Removing extraneous logging statements

* Undo vestigial changes

* Rename all canc -> cancel

* Use assert instead of require

* Remove testing changes

* Use assert instead of require

(cherry picked from commit 2ce32f8)
@ycombinator ycombinator merged commit 71ed0f6 into 8.10 Sep 14, 2023
7 of 10 checks passed
@ycombinator ycombinator deleted the mergify/bp/8.10/pr-3166 branch September 14, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

@ycombinator ycombinator Awaiting requested review from ycombinator

Assignees

@ycombinator ycombinator

Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @ycombinator @pierrehilbert