Diagnostics creates the necessary folder for -f argument #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
bug
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
- makes diagnostics command to create the necessary folders when a custom path is provided by the '-f' flag. - refactors the diagnosticCmd splitting it into smaller functions - add test createFile - rename logs_test.go createFile function to createFileEmpty so its name wont collide with the newly created 'createFile' function. add license headaer
AndersonQ
force-pushed
the
3339-fix-diagnostics-custom-path
branch
from
26f6494
to
cdcd1eb
Compare
🌐 Coverage report
|
rdner
approved these changes
Sep 1, 2023
pchila
reviewed
Sep 1, 2023
| @@ -99,7 +99,7 @@ func TestGetLogFilenames(t *testing.T) { | |||
|
|
|||
| t.Run("does not return non-log entries", func(t *testing.T) { | |||
| dir := t.TempDir() | |||
| createFile(t, dir, "excluded") | |||
| createFileEmpty(t, dir, "excluded") | |||
There was a problem hiding this comment.
Just checking: has this been renamed because of name collision within the same package?
pchila
approved these changes
Sep 1, 2023
|
Failing tests are unrelated. I'm forcing the merge. |
mergify bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
- makes diagnostics command to create the necessary folders when a custom path is provided by the '-f' flag. - refactors the diagnosticCmd splitting it into smaller functions - add test createFile - rename logs_test.go createFile function to createFileEmpty so its name wont collide with the newly created 'createFile' function. add license headaer (cherry picked from commit 4cd83bf)
pierrehilbert
pushed a commit
that referenced
this pull request
Sep 1, 2023
- makes diagnostics command to create the necessary folders when a custom path is provided by the '-f' flag. - refactors the diagnosticCmd splitting it into smaller functions - add test createFile - rename logs_test.go createFile function to createFileEmpty so its name wont collide with the newly created 'createFile' function. add license headaer (cherry picked from commit 4cd83bf) Co-authored-by: Anderson Queiroz <[email protected]>
cmacknz
pushed a commit
to cmacknz/elastic-agent
that referenced
this pull request
Sep 25, 2023
- makes diagnostics command to create the necessary folders when a custom path is provided by the '-f' flag. - refactors the diagnosticCmd splitting it into smaller functions - add test createFile - rename logs_test.go createFile function to createFileEmpty so its name wont collide with the newly created 'createFile' function. add license headaer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes how the diagnostics command handles the custom path to save the diagnostics. Right now if the custom file path to save the diagnostics on contains folders that do not exist, the diagnostics fail to create the file, consequently failing to save the diagnostics.
Why is it important?
It not clear on the diagnostics help the path to the file must exist, it'd be much easier for our users if the diagnostics is capable of creating the necessary folders.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Run the diagnostics command with the
-fflag, passing a path where at least one folder does not exist. It will fail on main and succeed with this change.E.g.:
Related issues
Logs
Questions to ask yourself