Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test while snapshot downloader cannot handle downgrades #3314

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

AndersonQ
Copy link
Member

Commit title: skip test while snapshot downloader cannot handle downgrades
Commit message: The snapshot downloader cannot handle downgrades what brakes this test between releases. An issue to fix the snapshot dowloader is filed: #3313

What does this PR do?

Rename TestStandaloneUpgradeWithGPGFallback to TestStandaloneDowngradeWithGPGFallback and skip it

Why is it important?

The snapshot downloader cannot handle downgrades what brakes this test between releases.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

The snapshot downloader cannot handle downgrades what brakes this test between releases.
An issue to fix the snapshot dowloader is filed: elastic#3313
@AndersonQ AndersonQ added flaky-test Unstable or unreliable test cases. skip-changelog labels Aug 29, 2023
@AndersonQ AndersonQ requested a review from pchila August 29, 2023 13:00
@AndersonQ AndersonQ self-assigned this Aug 29, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner August 29, 2023 13:00
@AndersonQ AndersonQ enabled auto-merge (squash) August 29, 2023 13:00
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-29T13:00:18.665+0000

  • Duration: 29 min 22 sec

Test stats 🧪

Test Results
Failed 1
Passed 6216
Skipped 47
Total 6264

Test errors 1

Expand to view the tests failures

Test / Matrix - PLATFORM = 'windows-2016 && windows-immutable' / Test / TestRemovePath – github.com/elastic/elastic-agent/internal/pkg/agent/install
    Expand to view the error details

     Failed 
    

    Expand to view the stacktrace

     === RUN   TestRemovePath
        uninstall_windows_test.go:54: 
            	Error Trace:	C:/Users/jenkins/workspace/_agent_elastic-agent-mbp_PR-3314/src/github.com/elastic/elastic-agent/internal/pkg/agent/install/uninstall_windows_test.go:54
            	Error:      	Received unexpected error:
            	            	could not remove "C:\\Users\\jenkins\\AppData\\Local\\Temp\\TestRemovePath3660284283\\001\\subdir", unretriable error: failed to open handle after rename for "C:\\Users\\jenkins\\AppData\\Local\\Temp\\TestRemovePath3660284283\\001\\subdir\\main.exe": The process cannot access the file because it is being used by another process.
            	Test:       	TestRemovePath
    --- FAIL: TestRemovePath (1.99s)
     
    

Steps errors 2

Expand to view the steps failures

Go unitTest
  • Took 9 min 56 sec . View more details here
  • Description: mage unitTest
Checks if running on a Unix-like node
  • Took 0 min 0 sec . View more details here
  • Description: script returned exit code 1

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Test / Matrix - PLATFORM = 'windows-2016 && windows-immutable' / Test / TestRemovePath – github.com/elastic/elastic-agent/internal/pkg/agent/install

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.368% (192/285) 👍
Classes 66.105% (353/534) 👍
Methods 52.921% (1105/2088) 👍 0.025
Lines 38.529% (12609/32726) 👎 -0.006
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member

cmacknz commented Aug 29, 2023

Test failures are unrelated, merging.

@cmacknz cmacknz disabled auto-merge August 29, 2023 14:21
@cmacknz cmacknz merged commit a8d8fce into elastic:main Aug 29, 2023
15 checks passed
@AndersonQ AndersonQ deleted the skip-broken-test branch August 30, 2023 13:33
blakerouse added a commit that referenced this pull request Sep 8, 2023
blakerouse added a commit that referenced this pull request Sep 8, 2023
…3314)" (#3385)

* Revert "skip test while snapshot downloader cannot handle downgrades (#3314)"

This reverts commit a8d8fce.

* Update upgrade_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip flaky-test Unstable or unreliable test cases. skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants