modify runtime variable 'install.in_default' with rpm/deb #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
bug
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
modify the `install.in_default` runtime protection variable so that when elastic-agent is installed via deb or rpm package manager it is still considered to be in the default path. This is necessary because endpoint supports being a component when elastic-agent is installed via rpm/deb.
leehinman
force-pushed
the
3280_rpm_deb_endpoint_fix
branch
from
cfbdd6b
to
7861fa7
Compare
faec
approved these changes
Aug 29, 2023
|
|
||
| // NOTE searching for english words might not be a great idea as far as portability goes. | ||
| // list all installed packages then search for paths.BinaryName? | ||
| // dpkg is strange as the remove and purge processes leads to the package bing isted after a remove, but not after a purge |
There was a problem hiding this comment.
bing isted -> being listed? 😄
|
|
||
| // check debian based systems (or systems that use dpkg) | ||
| // If the package has been installed, the status starts with "install" | ||
| // If the package has been removed (but not pruged) status starts with "deinstall" |
cmacknz
approved these changes
Aug 29, 2023
|
|
||
| // check rhel and sles based systems (or systems that use rpm) | ||
| // if package has been installed the query will returns the list of associated files. | ||
| // otherwise if uninstalled, or has never been installled status ends with "not installed" |
There was a problem hiding this comment.
Suggested change
| // otherwise if uninstalled, or has never been installled status ends with "not installed" | |
| // otherwise if uninstalled, or has never been installed status ends with "not installed" |
|
No new failures, merging. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* modify runtime variable 'install.in_default' with rpm/deb modify the `install.in_default` runtime protection variable so that when elastic-agent is installed via deb or rpm package manager it is still considered to be in the default path. This is necessary because endpoint supports being a component when elastic-agent is installed via rpm/deb. * fix typos in comments (cherry picked from commit 117d7de)
cmacknz
pushed a commit
that referenced
this pull request
Aug 29, 2023
) * modify runtime variable 'install.in_default' with rpm/deb modify the `install.in_default` runtime protection variable so that when elastic-agent is installed via deb or rpm package manager it is still considered to be in the default path. This is necessary because endpoint supports being a component when elastic-agent is installed via rpm/deb. * fix typos in comments (cherry picked from commit 117d7de) Co-authored-by: Lee E Hinman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
changes how the
install.in_defaultruntime protection variable is calculated on systems where elastic-agent is installed via deb or rpm package. Previously this would have returned false be cause the install path is not the same as thetar.gzinstall. However, endpoint knows how to operate when elastic-agent is installed as a deb or rpm, so now it will return true.Why is it important?
This is required because the runtime prevention was blocking the install of endpoint on systems installed via deb/rpm.
example:
Checklist
- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry in./changelog/fragmentsusing the changelog toolAuthor's Checklist
How to test this PR locally
Related issues
Questions to ask yourself