-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against 8.10 on main with the 8.11 agent by editing the package version #3277
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
🌐 Coverage report
|
@@ -360,3 +360,54 @@ func TestLess(t *testing.T) { | |||
}) | |||
} | |||
} | |||
|
|||
func TestPreviousMinor(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GetPrevMinor
method was discarding the prerelease and build metadata information.
Looks like we need to fix the upgrade tests to respect the test stack version:
This just keeps getting uglier... |
@cmacknz with @pchila's help I took another approach and just needed to set I think we can close this one and finish the review and any last change there. |
Yes that solution is much nicer, closing this one. |
The same as https://github.com/elastic/elastic-agent/pull/3276/files but with the package version file edit moved to happen in the right place.
Also fixes a bug in the GetPrevMinor() method of our version parser package. We need to keep this change.
I hope we get an 8.11 snapshot soon and we don't need this, but if we don't we'll merge it and then revert once the 8.11 snapshot is ready and work on less ugly solution for the next time this happens.