Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky test] skip FQDN integration test #3205

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Disable the flaky FQDN integration test

Why is it important?

CI needs to be green

Checklist

  • My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@AndersonQ AndersonQ added Team:Elastic-Agent Label for the Agent team flaky-test Unstable or unreliable test cases. backport-skip skip-changelog labels Aug 8, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner August 8, 2023 10:08
@AndersonQ AndersonQ self-assigned this Aug 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-08T11:43:03.441+0000

  • Duration: 25 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 6209
Skipped 31
Total 6240

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Aug 8, 2023

12:14:31 Error: test TestFQDN first statement must be a function call to define.Require
12:14:31 make: *** [Makefile:46: check-ci] Error 1

@ycombinator
Copy link
Contributor

12:14:31 Error: test TestFQDN first statement must be a function call to define.Require 12:14:31 make: *** [Makefile:46: check-ci] Error 1

Good catch. The t.Skip should be added after the define.Require. For example, see

func TestEnrollAndLog(t *testing.T) {
info := define.Require(t, define.Requirements{
OS: []define.OS{
{Type: define.Linux},
},
Stack: &define.Stack{},
Local: false,
Sudo: true,
})
t.Logf("got namespace: %s", info.Namespace)
t.Skip("Test is flaky; see https://github.com/elastic/elastic-agent/issues/3081")
suite.Run(t, &EnrollRunner{requirementsInfo: info})
}

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.734% (78/79) 👍
Files 66.549% (189/284) 👍
Classes 65.399% (344/526) 👍
Methods 52.258% (1076/2059) 👍
Lines 38.314% (12309/32127) 👍 0.016
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert merged commit 79fbc9f into elastic:main Aug 8, 2023
12 checks passed
@AndersonQ AndersonQ deleted the skip-flaky-FQDN-test branch August 8, 2023 12:55
@AndersonQ AndersonQ added the backport-v8.9.0 Automated backport with mergify label Aug 8, 2023
mergify bot pushed a commit that referenced this pull request Aug 8, 2023
* skip flaky test

(cherry picked from commit 79fbc9f)
AndersonQ added a commit that referenced this pull request Aug 9, 2023
(cherry picked from commit 79fbc9f)

Co-authored-by: Anderson Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip backport-v8.9.0 Automated backport with mergify flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants