-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.9](backport #2834 and #3164) Enhance mock fleet-server and add --proxy-url integration test and disable tests #3147
Conversation
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
🌐 Coverage report
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
* enhance test fleet-server Now a almost fully functional mock fleet-server can be instantiated with a single call to fleetservertest.NewServerWithHandlers. The only missing handlers are the upload handlers. testing/integration/proxy_url_test.go works as example on how to use the new features of the test fleet-server * add proxytest.Proxy: A naive proxy to be used on tests which allows to configure URL rewrites and check all the calls made to it. check the tests on testing/integration/proxy_url_test.go to see how to use proxytest.Proxy. * add integration tests for the fleet-server proxy The tests cover defining a proxy through --proxy-url and in the policy and the correct priority is respected * fix the Go version used on the Github workflows now it reads the version from the .go-version and not from the go.mod anymore. * increase the memory allocated to the elastic-agent vagrant box * allow -SNAPHOT versions to be passed to define.NewFixture * add more helper methods to testing.Fixture and Install accepts more flags * add version.Agent, a exported constant with the agent version (cherry picked from commit 732d7c0) # Conflicts: # version/version.go
d67b4dd
to
26e85bc
Compare
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
All of the proxy tests are currently flaky and fail regularly, see #3154 Disabling them while we investigate a fix to unblock CI.
Manual EDIT:
This backport backports 2 PRs:
The latter skips the tests added by the former while #3154 is addressed.
Therefore #3209 was closed in favour of this PR.
This is an automatic backport of pull request #2834 done by Mergify.
Cherry-pick of 732d7c0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com