Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests: fixed couldn't stat file error #3091

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Integration tests: fixed couldn't stat file error #3091

merged 2 commits into from
Jul 18, 2023

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Jul 17, 2023 •
edited
Loading

Figured out with @blakerouse the race condition while reading the output of git ls-files

Checklist

Related issues

Relates: #3068

@pazone pazone requested a review from a team as a code owner July 17, 2023 12:47
@pazone pazone changed the title DonAdded the git ls-files merged output to artifacts for troubleshooting… Don't merge: Added the git ls-files merged output to artifacts for troubleshooting… Jul 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot assigned pazone Jul 17, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T21:40:57.097+0000

  • Duration: 24 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 5939
Skipped 27
Total 5966

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 17, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.718% (77/78) 👍
Files 67.416% (180/267) 👍
Classes 66.329% (327/493) 👍
Methods 53.642% (1031/1922) 👍
Lines 39.836% (11758/29516) 👎 -0.007
Conditionals 100.0% (0/0) 💚

@pazone
Copy link
Contributor Author

pazone commented Jul 18, 2023

buildklite build this

@pazone pazone force-pushed the chore/integration_tests_add_troubleshooting_info branch from 648ffe4 to 1607c86 Compare July 18, 2023 20:01
@pazone pazone changed the title Don't merge: Added the git ls-files merged output to artifacts for troubleshooting… Integration tests: fixed couldn't stat file error Jul 18, 2023
@pazone pazone added skip-changelog backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify labels Jul 18, 2023
@mergify mergify bot removed the backport-skip label Jul 18, 2023
@blakerouse blakerouse removed backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify labels Jul 18, 2023
blakerouse
blakerouse approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@blakerouse blakerouse enabled auto-merge (squash) July 18, 2023 20:21
@blakerouse blakerouse merged commit 315fc8b into main Jul 18, 2023
9 checks passed
@blakerouse blakerouse deleted the chore/integration_tests_add_troubleshooting_info branch July 18, 2023 23:16
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
@pazone @mergify
Integration tests: fixed couldn't stat file race condition (#3091)
4b13cef 
(cherry picked from commit 315fc8b)
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
@pazone @mergify
Integration tests: fixed couldn't stat file race condition (#3091)
179827a 
(cherry picked from commit 315fc8b)
This was referenced Jul 18, 2023
Merged
Merged
pierrehilbert pushed a commit that referenced this pull request Jul 19, 2023
@mergify @pazone
Integration tests: fixed couldn't stat file race condition (#3091) (#…
dc443bc 
…3099)

(cherry picked from commit 315fc8b)

Co-authored-by: Pavel Zorin <[email protected]>
pierrehilbert pushed a commit that referenced this pull request Jul 19, 2023
@mergify @pazone
Integration tests: fixed couldn't stat file race condition (#3091) (#…
0ba85ea 
…3098)

(cherry picked from commit 315fc8b)

Co-authored-by: Pavel Zorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@pazone pazone

Labels
backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pazone @elasticmachine @blakerouse