Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test - Fetcher must collect SHAs #3073

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented Jul 13, 2023

What does this PR do?

This PR adds support for fetchers to handle sha512 hashes so that the elastic agent artifacts can be used as version to upgrade to using a --sourceURI flag (that will be in a follow-up PR)

Why is it important?

This change open up some upgrade test scenarios where we can use the local package on disk instead of waiting for it to be available through artifact API

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila requested a review from a team as a code owner July 13, 2023 06:23
@pchila pchila self-assigned this Jul 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pchila
Copy link
Member Author

pchila commented Jul 13, 2023

@blakerouse could you have a look at this?
It slightly changes the runner signature for the Prepare() function and it may impact the work on the windows runner slightly...

Prepare(ctx context.Context, c *ssh.Client, logger Logger, arch string, goVersion string, repoArchive string, buildPaths []string) error

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-14T15:50:10.259+0000

  • Duration: 24 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 5975
Skipped 27
Total 6002

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.718% (77/78) 👍
Files 67.416% (180/267) 👍
Classes 66.397% (328/494) 👍
Methods 53.89% (1039/1928) 👍 0.024
Lines 40.123% (11899/29656) 👍 0.008
Conditionals 100.0% (0/0) 💚

@pchila
Copy link
Member Author

pchila commented Jul 13, 2023

buildkite test this

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jul 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pchila pchila requested a review from ycombinator July 14, 2023 15:31
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pchila
Copy link
Member Author

pchila commented Jul 14, 2023

/test

@pchila
Copy link
Member Author

pchila commented Jul 17, 2023

buildkite test this

@pchila pchila merged commit fad23db into elastic:main Jul 17, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants