Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buildkite pipeline to build elastic-agent binary artifacts #3046

Merged
merged 29 commits into from
Jul 26, 2023
Merged

Add buildkite pipeline to build elastic-agent binary artifacts #3046

merged 29 commits into from
Jul 26, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 10, 2023

What does this PR do?

Adds a new buildkite pipeline to release the elastic-agent binary artifacts

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in ./changelog/fragments using the changelog tool
    - [ ] I have added an integration test or an E2E test

Related issues

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2023

⚠️ The sha of the head commit of this PR conflicts with #2812. Mergify cannot evaluate rules on this PR. ⚠️

@marc-gr marc-gr mentioned this pull request Jul 10, 2023
Closed
3 tasks
@marc-gr marc-gr changed the title Add DRA pipeline Add buildkite pipeline to build elastic-agent binary artifacts Jul 10, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 10, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-26T09:02:13.757+0000

  • Duration: 25 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 6099
Skipped 27
Total 6126

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 10, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.718% (77/78) 👍
Files 68.657% (184/268) 👍
Classes 67.606% (336/497) 👍
Methods 54.222% (1053/1942) 👍
Lines 40.301% (12036/29865) 👍 0.013
Conditionals 100.0% (0/0) 💚

@marc-gr marc-gr force-pushed the feat/bindist-buildkite-pipeline branch 20 times, most recently from 15f93f5 to fdcf5c5 Compare July 11, 2023 10:06
@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 14, 2023

Changes applied and DRA run succeeded https://buildkite.com/elastic/elastic-agent-binary-dra/builds/28

https://artifacts-snapshot.elastic.co/elastic-agent-core/8.10.0-e86ee1ed/summary-8.10.0-SNAPSHOT.html
https://artifacts-staging.elastic.co/elastic-agent-core/8.10.0-a117b84b/summary-8.10.0.html

alexsapran
alexsapran reviewed Jul 14, 2023
View reviewed changes
.buildkite/pipeline.elastic-agent-binary-dra.yml Outdated Show resolved Hide resolved
.buildkite/hooks/pre-command Outdated Show resolved Hide resolved
@marc-gr marc-gr added backport-v8.9.0 Automated backport with mergify and removed backport-skip labels Jul 14, 2023
@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 14, 2023

/dra

alexsapran
alexsapran approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@alexsapran alexsapran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, thanks for the effort put in this Marc

@marc-gr marc-gr enabled auto-merge (squash) July 14, 2023 15:12
pchila
pchila reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks fine but I still have a couple of questions about some part of the DRA build process

.buildkite/scripts/steps/dra-publish.sh Show resolved Hide resolved
.buildkite/scripts/steps/dra-publish.sh Show resolved Hide resolved
catalog-info.yaml Show resolved Hide resolved
@alexsapran
Copy link
Contributor

/test

@alexsapran
Copy link
Contributor

/test

@alexsapran alexsapran added the backport-v8.8.0 Automated backport with mergify label Jul 26, 2023
@marc-gr marc-gr merged commit 30dff79 into main Jul 26, 2023
10 checks passed
@marc-gr marc-gr deleted the feat/bindist-buildkite-pipeline branch July 26, 2023 09:48
mergify bot pushed a commit that referenced this pull request Jul 26, 2023
@marc-gr @mergify
Add buildkite pipeline to build elastic-agent binary artifacts (#3046)
60faa3e 
* Add DRA pipeline

* Fix mage and go check

* Force trigger

* Change permissions

* source bootstrap

* ignore existing folder

* Generate dependencies report

* Split in various steps and move creds to pre-command

* Fix script name

* Use agent to upload artifacts

* Expose env var to force publish for testing

* Generalize dra-publish.sh

* Use version for dependencies file

* Fix dry run

* Run test dra publish

* Fix version

* Only upload distributions

* Fix glob

* Only add spanshot on build

* Fix permissions on downloaded artifacts

* Remove test env vars

* Stop calling buildkite-agent in scripts

* Add vars to test

* Add correct command to staging

* creat local var

* Create local var

* Remove testing force var

* Remove test vars

(cherry picked from commit 30dff79)

# Conflicts:
#	.buildkite/pipeline.elastic-agent-binary-dra.yml
#	.buildkite/pipeline.yml
#	.buildkite/scripts/integration_tests.sh
#	catalog-info.yaml
mergify bot pushed a commit that referenced this pull request Jul 26, 2023
@marc-gr @mergify
Add buildkite pipeline to build elastic-agent binary artifacts (#3046)
662201a 
* Add DRA pipeline

* Fix mage and go check

* Force trigger

* Change permissions

* source bootstrap

* ignore existing folder

* Generate dependencies report

* Split in various steps and move creds to pre-command

* Fix script name

* Use agent to upload artifacts

* Expose env var to force publish for testing

* Generalize dra-publish.sh

* Use version for dependencies file

* Fix dry run

* Run test dra publish

* Fix version

* Only upload distributions

* Fix glob

* Only add spanshot on build

* Fix permissions on downloaded artifacts

* Remove test env vars

* Stop calling buildkite-agent in scripts

* Add vars to test

* Add correct command to staging

* creat local var

* Create local var

* Remove testing force var

* Remove test vars

(cherry picked from commit 30dff79)

# Conflicts:
#	.buildkite/pipeline.elastic-agent-binary-dra.yml
#	.buildkite/pipeline.yml
#	catalog-info.yaml
This was referenced Jul 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsapran alexsapran alexsapran approved these changes

@pchila pchila pchila approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@marc-gr marc-gr

Labels
backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify enhancement New feature or request skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marc-gr @elasticmachine @DaveSys911 @alexsapran @pchila