-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove race detector platform restrictions and enable it in CI #2790
Conversation
The race detector is now supported on arm64 and aarch64.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures> Show only the first 10 test failures
|
Closing in favor of #3096 |
(copied from @cmacknz at #2743 so I can work through the remaining failed cases):
We discovered in a recent PR that the RACE_DETECTOR environment variable seemingly was not having any effect (#2729 (comment)), it turns out it is ignored on arm64. This is now an unnecessary restriction.
I've also enabled the race detector in CI, I'll need to see what this does to the test time on each platform first though. We will keep it at least for Linux.