Skip to content

Commit

Permalink
Move linter directive along with goroutine invocation
Browse files Browse the repository at this point in the history
  • Loading branch information
ycombinator committed Jul 14, 2023
1 parent fe067b4 commit f42f3ab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/component/runtime/service_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ func (cr *cmdRetrier) Start(
// returns a non-nil error. We will block here until executeCommand
// returns a nil error, indicating that the command being executed has
// successfully completed execution.
//nolint: errcheck // No point checking the error inside the goroutine.
err := backoff.RetryNotify(
func() error {
err := executeCommand(cmdCtx, log, binaryPath, args, env, timeout)
Expand Down Expand Up @@ -211,6 +210,7 @@ func (cr *cmdRetrier) Start(
// want to block. So we execute the command with retries in its own
// goroutine.
if !shouldBlock {
//nolint: errcheck // No point checking the error from goroutine.
go retryFunc()
return nil
}
Expand Down

0 comments on commit f42f3ab

Please sign in to comment.