perf: improve memory usage in apmhttp module #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
approved these changes
Oct 26, 2023
| @@ -139,11 +139,11 @@ func (r *roundTripper) RoundTrip(req *http.Request) (*http.Response, error) { | |||
| func SetHeaders(req *http.Request, traceContext apm.TraceContext, propagateLegacyHeader bool) { | |||
| headerValue := FormatTraceparentHeader(traceContext) | |||
| if propagateLegacyHeader { | |||
| req.Header.Set(ElasticTraceparentHeader, headerValue) | |||
| req.Header[ElasticTraceparentHeader] = []string{headerValue} | |||
There was a problem hiding this comment.
+1 on the change but out of curiosity, won't they have the same allocs? Probably a bit high CPU cost in case of using Set due to canonical conversion of header keys but allocation wise I think they would be same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few performance improvements related to memory usage:
Setif the key is a constant value (avoid alloc in canonical conversion)