Add sortable admin list feature #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdejacobet
force-pushed
the
sortable-admin-list
branch
from
2c47634
to
35fb8ba
Compare
mazsudo
suggested changes
Mar 16, 2018
Bladrak
requested changes
Mar 16, 2018
bdejacobet
force-pushed
the
sortable-admin-list
branch
6 times, most recently
from
8ff3bdd
to
593b646
Compare
bdejacobet
commented
Mar 28, 2019
| { | ||
| switch ($name) { | ||
| case 'list': | ||
| return 'CanalPlusAwakenAdminBundle:CRUD:list_sortable.html.twig'; |
There was a problem hiding this comment.
should be AppBundle and updated by user when he install it. It must be indicated in documentation.
Bladrak
requested changes
Mar 28, 2019
| { | ||
| switch ($name) { | ||
| case 'list': | ||
| return 'CanalPlusAwakenAdminBundle:CRUD:list_sortable.html.twig'; |
| * | ||
| */ | ||
|
|
||
| const useLogger = window.location.pathname.match(/app_dev.php/g); |
| // Set position | ||
| $connection = $this->doctrine->getConnection(); | ||
| $stmt = $connection->executeQuery( | ||
| sprintf('SELECT MAX(position) as position FROM %s;', $tableName), |
There was a problem hiding this comment.
Is it possible to use a statement with parameters rather than a sprintf?
bdejacobet
force-pushed
the
sortable-admin-list
branch
from
593b646
to
a3c733f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because it is a new feature.
Changelog
To do
Subject
You can update an admin to get a sortable list if your entities must be ordered