Daikon handling in CI, cleanups #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
commented
Aug 8, 2024
.github/workflows/ci.yml
Outdated
| # JDK 21 used by sanity before | ||
| java: [{version: '8', experimental: false}, | ||
| {version: '11', experimental: false}, | ||
| {version: '17', experimental: false}, | ||
| {version: '22', experimental: true}, | ||
| {version: '22', experimental: false}, |
There was a problem hiding this comment.
This change means that the JDK 22 runtime is now also used to run the test cases - before, the JDK 21 runtime was used, as is the case for experimental platforms.
This reveals the failure with the non-junit tests, which is #826. So we either keep JDK 22 experimental or fix #826.
I can't reproduce the failures we get with :dataflow:busyExpressionTest and the last few runs don't produce them. Not sure what is causing this.
There was a problem hiding this comment.
:dataflow:busyExpressionTest fails again as soon as I remove the debugging for it in 56c9d40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.