Support recursive datatypes in egglog #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ast/mod.rs
Outdated
| Err((head, args)) => list!("sort", name, list!(head, ++ args)), | ||
| }) | ||
| .collect(); | ||
| list!("datatypes", ++ datatypes) |
There was a problem hiding this comment.
Should this be datatype*? Hm, I wonder if there are no tests for these?
There was a problem hiding this comment.
Good catch! For NCommand, cases like this would be caught by resugared tests (which re-run same tests over programs converted from ASTs), but we don't have tests for Command (which is immediately desugared into NCommand)
saulshanabrook
requested changes
Oct 4, 2024
src/ast/mod.rs
Outdated
| @@ -450,6 +450,8 @@ pub type Command = GenericCommand<Symbol, Symbol>; | |||
|
|
|||
| pub type Subsume = bool; | |||
|
|
|||
| pub type Subdatatypes = Result<Vec<Variant>, (Symbol, Vec<Expr>)>; | |||
There was a problem hiding this comment.
Are you using Result to separate sorts vs datatypes? I think it might be clearer if you have a custom enum instead? Unless I'm missing something, just when trying to follow the code.
There was a problem hiding this comment.
Yeah, good point. I have changed it to use a custom enum.
…g-smol into yihozhang-recursive-datatype
Co-authored-by: Saul Shanabrook <[email protected]>
saulshanabrook
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually accidentally pushed this to
main... which is bad (now reverted). I have updated repo settings so that no one can directly push tomain