-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the interactive visualizer #426
Add support for the interactive visualizer #426
Conversation
I have updated this PR to support transitioning between multiple e-graphs, the last thing I wanted to add before calling the visualizer good for now! Untitled2.movIf anyone could try this locally and make sure it works, then we can get this in. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!! Thank you for making the visualizer better!
Yes, it does! I thought they mainly were fine, except it's just not great when the buttons wrap. That's based on your screen size and the addition of the extra toggle. I think the changes are from using tailwindcss to style the visualizer and it pulls in some "pre-flight" styles:
|
@saulshanabrook I see! Thanks for the explanation. Some differences I noticed
1 and 2 seem fine, I'm not sure about 3 (the original spacing looks slightly more natural), and I think we should fix 4 and 5. What do you think? |
Thanks @yihozhang! I published a new version that limited the preflight styles to just my component (using this) and I think it fixed it? For reference I had to purge the JS cache of these two URLs after publishing to load the new one:
|
Yes, thank you!! @saulshanabrook |
This PR adds the ability to try the new interactive visualizer in the web editor. I still kept the original graphviz visualizer as default, while this while let you switch between them:
new.mov
The new visualizer includes the following features compared to the existing editor:
Moreover, it can serve as a base to build future interactive features that would be helpful.