Draft: more fix for seminaive #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some remaining issues of #93 (which was described in #142) that the right-hand side of the set is not a function but bound to a function in the previous let binding. eg:
(rule ((= f0 (f 0))) ((let a (f 3)) (set (f 0) a)))The previous fix didn't add semi-naive rule to match the variable bonded function call, and this fix conservatively moves all let binding to the body to ensure all functions are matched.
This PR also removes
Action::SetNoTrack, which should be unnecessary, and turn off the semi-naive transformation in final_desugar pass to avoid auto-generated let binding being moved again.A possible optimization is to do liveness analysis instead of moving all let binding to the body, but might be complex.
However, this fix is blocked by #143, as a test cannot pass without #143 being fixed.