Separate optimization of functions #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oflatt
force-pushed
the
oflatt-separate-compilation
branch
from
f0bf927
to
33a7c6a
Compare
yihozhang
reviewed
Nov 13, 2024
| pub fn build_program( | ||
| program: &TreeProgram, | ||
| inline_program: Option<&TreeProgram>, |
There was a problem hiding this comment.
Do we need both program and inline_program? How are they different? Is inline_program the "full" program and program a batch of programs to be optimized?
There was a problem hiding this comment.
The inline program is the original program for this iteration- if you make them the same, you might inline something that has already been inlined, causing blowup
yihozhang
reviewed
Nov 13, 2024
| br v4_ .b12_ .b13_; | ||
| .b12_: | ||
| v11_: int = id c5_; | ||
| v11_: int = select v4_ c5_ c10_; |
There was a problem hiding this comment.
Nice that the select optimization is applied. Any idea why it was not applied before?
There was a problem hiding this comment.
It's flaky, probably an extraction problem or same cost
yihozhang
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds separate optimization of functions. This allows us to run the egraph separately for different functions, while still doing inlining and all our optimizations we did before.
We could also in the future choose which functions to batch together.
The extractor is now aware of what function it is extracting, which I plan to leverage soon for a better cost model of recursive functions.