Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better select rule #653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Better select rule #653

wants to merge 2 commits into from

Conversation

ajpal
Copy link
Collaborator

@ajpal ajpal commented Nov 1, 2024

Subsumes the old rules.
select_simple.rs before optimization
image

after optimization
image

also gcd.bril is now just a big loop with selects, no ifs:
image

@ajpal ajpal requested a review from oflatt November 1, 2024 17:54
oflatt
oflatt requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Now that it's a more serious optimization, could you give it a separate ruleset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oflatt oflatt oflatt requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajpal @oflatt