-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix state passthrough (banish the shadow realm) #622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Fischman
force-pushed
the
fix-state-passthrough
branch
from
June 4, 2024 04:28
602cb9e
to
13876d0
Compare
ajpal
reviewed
Jun 4, 2024
I'd like to see a solid nightly run before we merge, but code lgtm! |
Alex-Fischman
force-pushed
the
fix-state-passthrough
branch
from
June 5, 2024 21:20
e523f4f
to
1aa395a
Compare
I just looked at eggcc-notify and the nightly for main has been failing since May 31st. Since I rebased my branch is also failing. I don't know why. |
Alex-Fischman
force-pushed
the
fix-state-passthrough
branch
from
June 7, 2024 03:19
1aa395a
to
40e43e7
Compare
Rebased on |
ajpal
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the state edge passthrough performance bug by "tying the knot" so that loop contexts point to the loop itself (instead of to the pre-context version of the loop). To this end, it also:
add_context.rs
dag_in_context/src/lib.rs
dag_in_context
subcrate to add the unions to theegglog_test
add_context.rs
, and because substitution adds context, we have to pass aContextCache
throughout our code.fuction_inlining.egg
filedebug-helper.egg
file