Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bril ops #611

Merged
merged 8 commits into from
May 29, 2024
Merged

Add bril ops #611

merged 8 commits into from
May 29, 2024

Conversation

ajpal
Copy link
Collaborator

@ajpal ajpal commented May 28, 2024

No description provided.

@ajpal ajpal requested a review from oflatt May 28, 2024 17:48
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
It's probably worth adding some bril tests that use the new ops- that way it checks automatically that type checking is working, ect

"Add" | "PtrAdd" | "Sub" | "And" | "Or" | "Not" => 10.,
"FAdd" | "FSub" => 50.,
"Add" | "PtrAdd" | "Sub" | "And" | "Or" | "Not" | "Shl" | "Shr" => 10.,
"FAdd" | "FSub" | "Fmax" | "Fmin" => 50.,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any justification for these costs it's worth a comment. Otherwise, it's fine we can play with these

@ajpal ajpal merged commit 698bac1 into main May 29, 2024
4 checks passed
@ajpal ajpal deleted the ajpal-bril-ops branch May 29, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants