Add typing rules for functions/calls #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oflatt
reviewed
Jan 29, 2024
| ((HasType (Arg id) in-ty)) | ||
| :ruleset type-analysis) | ||
|
|
||
| (rule ( |
There was a problem hiding this comment.
We should probably have a rule that errors when out-ty for the function and out-ty for the body are different
oflatt
requested changes
Jan 29, 2024
| ((HasType f (FuncT in-ty out-ty))) | ||
| :ruleset type-analysis) | ||
|
|
||
| (rule ( |
There was a problem hiding this comment.
Similar: need an error when call type and argument type do not match
| " | ||
| ); | ||
| crate::run_test(build, &check) | ||
| } |
There was a problem hiding this comment.
Add a test or two that test erroring cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.