fix unused results in tests

egraphs-good · Jan 29, 2024 · cf7a974 · cf7a974
1 parent 2040f8b
commit cf7a974
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 201 deletions.
diff --git a/tree_shared/src/id_analysis.rs b/tree_shared/src/id_analysis.rs
@@ -122,7 +122,7 @@ fn test_id_analysis_no_invalid_entry() {
     let build = "(let some-expr (Not (Boolean (Id (i64-fresh!)) false))";
     let check = "(fail (check (ExprHasRefId some-expr any-id)))";
 
-    let _ = crate::run_test(build, check);
+    crate::run_test(build, check).unwrap()
 }
 
 // Create an id conflict for an Expr on purpose and check that we catch it
@@ -136,7 +136,7 @@ fn test_id_analysis_expr_id_conflict_panics_if_valid() {
         (ExprIsValid conflict-expr)";
     let check = "";
 
-    let _ = crate::run_test(build, check);
+    crate::run_test(build, check).unwrap()
 }
 
 #[test]
@@ -150,7 +150,7 @@ fn test_id_analysis_listexpr_id_conflict_panics() {
         (ListExprIsValid conflict-expr)";
     let check = "";
 
-    let _ = crate::run_test(build, check);
+    crate::run_test(build, check).unwrap()
 }
 
 #[test]
@@ -165,5 +165,5 @@ fn test_shared_unique_id_mix_panics() {
                 (Num id2 1)))
         (ExprIsValid conflict-expr)";
     let check = "";
-    let _ = crate::run_test(build, check);
+    crate::run_test(build, check).unwrap()
 }
diff --git a/tree_shared/src/ir.rs b/tree_shared/src/ir.rs
@@ -1,4 +1,7 @@
-use std::iter;
+use std::{
+    fmt::{Display, Formatter},
+    iter,
+};
 use strum_macros::EnumIter;
 
 #[derive(Clone, Copy, Debug, PartialEq)]
@@ -118,6 +121,12 @@ impl Field {
     }
 }
 
+impl Display for Constructor {
+    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        write!(f, "{}", self.name())
+    }
+}
+
 impl Constructor {
     pub(crate) fn name(&self) -> &'static str {
         match self {

diff --git a/tree_shared/src/lib.rs b/tree_shared/src/lib.rs
@@ -1,5 +1,6 @@
 pub mod ast;
 pub(crate) mod deep_copy;
+pub(crate) mod error_checking;
 pub(crate) mod id_analysis;
 pub mod interpreter;
 pub(crate) mod ir;
@@ -142,6 +143,7 @@ pub fn run_test(build: &str, check: &str) -> Result {
             &deep_copy::deep_copy_rules().join("\n"),
             include_str!("sugar.egg"),
             &util::rules().join("\n"),
+            &error_checking::error_checking_rules().join("\n"),
             &id_analysis::id_analysis_rules().join("\n"),
             // optimizations
             include_str!("simple.egg"),

diff --git a/tree_shared/src/switch_rewrites.rs b/tree_shared/src/switch_rewrites.rs
diff --git a/tree_shared/src/type_analysis.rs b/tree_shared/src/type_analysis.rs
@@ -163,7 +163,7 @@ fn loop_pred_boolean() {
   (run-schedule (saturate type-analysis))";
     let check = "";
 
-    let _ = crate::run_test(build, check);
+    crate::run_test(build, check).unwrap()
 }
 
 #[test]
@@ -176,7 +176,7 @@ fn loop_args1() {
   (run-schedule (saturate type-analysis))";
     let check = "";
 
-    let _ = crate::run_test(build, check);
+    crate::run_test(build, check).unwrap()
 }
 
 #[test]
@@ -194,5 +194,5 @@ fn loop_args3() {
   (run-schedule (saturate type-analysis))";
     let check = "";
 
-    let _ = crate::run_test(build, check);
+    crate::run_test(build, check).unwrap()
 }