issue link, snapshots

egraphs-good · Nov 13, 2024 · 62f67d0 · 62f67d0
1 parent eca6e01
commit 62f67d0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/dag_in_context/src/optimizations/loop_strength_reduction.egg b/dag_in_context/src/optimizations/loop_strength_reduction.egg
@@ -96,7 +96,8 @@
 
         ; Subsume the multiplication in the new loop to prevent
         ; from firing loop strength reduction again on the new loop
-        ; subsumption needs something to subsume, add it here
+        ; Workaround of egglog issue: https://github.com/egraphs-good/egglog/issues/462
+        ; add the expression we are about to subsume
         (let before
           (Bop (Mul) new-c (Get replace-arg i)))
         ; now subsume it

diff --git a/dag_in_context/src/utility/util.egg b/dag_in_context/src/utility/util.egg
@@ -68,6 +68,8 @@
 (ruleset subsume-after-helpers)
 ;; After running the `saturating` ruleset, these if statements can be subsumed
 (relation ToSubsumeIf (Expr Expr Expr Expr))
+;; Workaround of https://github.com/egraphs-good/egglog/issues/462
+;; Make sure the if we are subsuming is present
 (rule ((ToSubsumeIf a b c d)
        (If a b c d))
       ((subsume (If a b c d)))

diff --git a/src/rvsdg/snapshots/eggcc__rvsdg__optimize_direct_jumps__add_block_ind_test.snap b/src/rvsdg/snapshots/eggcc__rvsdg__optimize_direct_jumps__add_block_ind_test.snap