Consistently export stylesheet
#456
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
==========================================
+ Coverage 92.94% 93.31% +0.36%
==========================================
Files 10 10
Lines 326 329 +3
Branches 115 116 +1
==========================================
+ Hits 303 307 +4
+ Misses 22 21 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
circle.yml
Outdated
| version: 2 | ||
| jobs: | ||
| build: | ||
| working_directory: ~/repo | ||
| docker: | ||
| - image: circleci/node:lts | ||
| - image: circleci/node:14 |
There was a problem hiding this comment.
We'll need to update packages to use latest node
circle.yml
Outdated
| @@ -28,4 +27,4 @@ jobs: | |||
| command: bash <(curl -s https://codecov.io/bash) | |||
| - run: | |||
| name: release | |||
| command: npx semantic-release | |||
| command: npx semantic-release@15.13.30 | |||
There was a problem hiding this comment.
We will need to upgrade node to use latest semantic-release
|
@egoist Is this something you can help take a look at? |
dougalg
force-pushed
the
consistent-stylesheet-export
branch
from
9a6b1f6
to
89670b9
Compare
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @babel/[email protected], @babel/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected] |
Add an export to expose the CSS stylesheet to the end user with the `stylesheet` name for all use cases. This reduces code duplication, for cases where the CSS was previously exported twice, and also makes the interface simpler and more consistent for users with a variety of use cases who may need access to the stylesheet directly.
dougalg
force-pushed
the
consistent-stylesheet-export
branch
from
4c8e356
to
b430480
Compare
dougalg
force-pushed
the
consistent-stylesheet-export
branch
2 times, most recently
from
7f64432
to
1b5a160
Compare
dougalg
force-pushed
the
consistent-stylesheet-export
branch
from
bed2ce5
to
badc851
Compare
dougalg
force-pushed
the
consistent-stylesheet-export
branch
from
e37ab87
to
53439db
Compare
dougalg
force-pushed
the
consistent-stylesheet-export
branch
from
53439db
to
529b843
Compare
Add an export to expose the CSS stylesheet to the end user with the
stylesheetname for all use cases.This reduces code duplication, for cases where the CSS was previously exported twice, and also makes the interface simpler and more consistent for users with a variety of use cases who may need access to the
stylesheet directly.