feat: added dockerfile and docker image push workflow for edx-analytics-dashboard #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BilalQamar95
changed the title
edx-analytics-dashboard
| # No need to activate insights virtualenv as it is already activated by putting in the path | ||
| RUN virtualenv -p python${PYTHON_VERSION} --always-copy ${INSIGHTS_VENV_DIR} | ||
|
|
||
| ENV PATH="${INSIGHTS_CODE_DIR}/node_modules/.bin:$PATH" |
There was a problem hiding this comment.
Need to specify workdir here
WORKDIR ${INSIGHTS_CODE_DIR}/
# Create required directories for requirements
RUN mkdir -p requirements
| RUN pip install virtualenv | ||
|
|
||
| # Create required directories for requirements | ||
| RUN mkdir -p requirements |
There was a problem hiding this comment.
Will create this dir after specifying workdir
|
|
||
| FROM app as dev | ||
|
|
||
| RUN curl -L -o requirements/local.txt https://raw.githubusercontent.com/edx/edx-analytics-dashboard/master/requirements/local.txt |
There was a problem hiding this comment.
No need to download this file at this stage.
We are extending dev from app so it should be already available.
UsamaSadiq
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19
Description
PR adds
Dockerfilealong with workflow to build & push docker image foredx-analytics-dashboard.