Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #228

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 20, 2024
@BilalQamar95 BilalQamar95 requested a review from a team as a code owner September 20, 2024 09:59
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 20, 2024
Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is not a Tutor supported MFE and is private to 2u/edX, I think this is okay to merge any time and we don't have to wait for the Sumac cut.

What are your thoughts on this?

@MaxFrank13 MaxFrank13 merged commit 8bad89c into main Sep 27, 2024
4 checks passed
@MaxFrank13 MaxFrank13 deleted the bilalqamar95/node20-upgrade-3 branch September 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants