fix: Use override for school name and url #18
Conversation
| {orgName} | ||
| </Chip> | ||
| ))} | ||
| <Chip className="chip-max-width"> |
There was a problem hiding this comment.
Is there really ever more than one partner in the data? There is only ever a single override.
Do we need a more complex approach that uses the singular override OR the array of partners?
There was a problem hiding this comment.
It's pretty rare, but there are some instances where there are more than one partner in the data. Here's one example:
Given that, I believe we should develop the more complex approach to cover our bases until we know only one is necessary.
There was a problem hiding this comment.
After further consideration, since we are only grabbing one name at
And considering that this value is prioritized over the partner value(s), we probably want to keep that pattern and just grab the first one in the partner list.
There was a problem hiding this comment.
Is there a case where there is more than one partner AND the override fields? The overrides are singular, and not arrays.
MaxFrank13
force-pushed
the
APER-2698/OverrideOrgNameLogo
branch
from
7c970ae
to
52a6978
Compare
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage ? 91.57%
=======================================
Files ? 30
Lines ? 368
Branches ? 66
=======================================
Hits ? 337
Misses ? 30
Partials ? 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MaxFrank13
force-pushed
the
APER-2698/OverrideOrgNameLogo
branch
from
52a6978
to
749906e
Compare
|
Old view: New view: |
If available, use the override fields for the preferred name of the institution and the override for the logo.