fix: extractProductKeys breaking recommendations view #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFrank13
force-pushed
the
mfrank/test-recs-error
branch
from
184595c
to
6f44b82
Compare
cdeery
reviewed
Jul 24, 2023
| @@ -56,7 +57,8 @@ const ViewResults = () => { | |||
| }; | |||
|
|
|||
| getAllRecommendations() | |||
| .catch(() => { | |||
| .catch((err) => { | |||
There was a problem hiding this comment.
Nice. We should definitely be logging errors!
cdeery
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address an error that was discovered in Skills Builder where recommendations were not being returned, despite seeing a successful in the Network tab. The application was failing silently because we didn't have proper logging for catching these errors. This has been added and the utility function that was causing the error has been modified to prevent it from happening again. More details in the ticket below:
APER-2690
A test has been added and it has been confirmed that this test will fail if these changes to
extractProductKeysare removed.