feat: migration fix #227
Merged
feat: migration fix #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
ilee2u
approved these changes
Oct 7, 2024
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AlterModelOptions( |
There was a problem hiding this comment.
Out of curiosity, how are you doing a migration w/o a change to the model being present in this PR?
There was a problem hiding this comment.
The model actually did change just not in our code. It was the base class for that model, TimeStampedModel that is now different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
During the Python 3.11 upgrade (#189) a few lines got dropped from our Makefile that allowed us to override the common constraints for
django-simple-history. This caused us to automatically revert back to3.0.0when the upgrade bot ran which produces a slightly different makemigrations output. Migrations created by versions<3.1.1will cause edx-platform checks to fail since those checks include running makemigrations usingdjango-simple-history=3.4.0and ensuring there are no changes.Pre-Merge Checklist:
edx_name_affirmation/__init__.pyif these changes are to be released. See OEP-47: Semantic Versioning.CHANGELOG.rst.Post-Merge: