Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create lms retirement listener for verified name #221

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

varshamenon4
Copy link
Member

@varshamenon4 varshamenon4 commented Sep 10, 2024

Description:

The purpose of this ticket is to hook the VerifiedName model of the edx-name-affirmation application into the LMS retirement pipeline.

openedx/platform-roadmap#367

JIRA:

COSMO-465

Pre-Merge Checklist:

  • Updated the version number in edx_name_affirmation/__init__.py if these changes are to be released. See OEP-47: Semantic Versioning.
  • Described your changes in CHANGELOG.rst.
  • Confirmed Github reports all automated tests/checks are passing.
  • Approved by at least one additional reviewer.

Post-Merge:

  • Create a tag matching the new version number.

Copy link

github-actions bot commented Sep 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  edx_name_affirmation
  __init__.py
  models.py
  signals.py
  edx_name_affirmation/tests
  test_signals.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member Author

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review! Had a couple of questions about python version and testing. Unit tests are added but I still need to test locally.

requirements/base.txt Outdated Show resolved Hide resolved
edx_name_affirmation/tests/test_signals.py Show resolved Hide resolved
edx_name_affirmation/tests/test_signals.py Show resolved Hide resolved
Copy link
Member

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I think we should clean up the requirements files before merge, but my other recommendations are just nits - you can take them or leave them 🙂.

requirements/base.txt Outdated Show resolved Hide resolved
edx_name_affirmation/tests/test_signals.py Show resolved Hide resolved
edx_name_affirmation/tests/test_signals.py Show resolved Hide resolved
Copy link
Member

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@varshamenon4 varshamenon4 force-pushed the varshamenon4/feat-create-lms-retirement-listener branch from cdfcb96 to 5e79fcc Compare September 17, 2024 00:27
@varshamenon4 varshamenon4 force-pushed the varshamenon4/feat-create-lms-retirement-listener branch from b221fc3 to a79969f Compare September 17, 2024 14:50
@varshamenon4 varshamenon4 merged commit a2ff658 into main Sep 17, 2024
6 checks passed
@varshamenon4 varshamenon4 deleted the varshamenon4/feat-create-lms-retirement-listener branch September 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants