-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create lms retirement listener for verified name #221
feat: create lms retirement listener for verified name #221
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review! Had a couple of questions about python version and testing. Unit tests are added but I still need to test locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I think we should clean up the requirements files before merge, but my other recommendations are just nits - you can take them or leave them 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
cdfcb96
to
5e79fcc
Compare
b221fc3
to
a79969f
Compare
Description:
The purpose of this ticket is to hook the VerifiedName model of the edx-name-affirmation application into the LMS retirement pipeline.
openedx/platform-roadmap#367
JIRA:
COSMO-465
Pre-Merge Checklist:
edx_name_affirmation/__init__.py
if these changes are to be released. See OEP-47: Semantic Versioning.CHANGELOG.rst
.Post-Merge: