-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate edx-sphinx-theme #763
Conversation
docs/conf.py
Outdated
href="https://openedx.org" | ||
property="cc:attributionName" | ||
rel="cc:attributionURL" | ||
>Axim Collaborative</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this appropriate for edx-arch-experiments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same question for license)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @timmc-edx, you are absolutely right about the Author, license and copyright information. Can I please have the exact data that we need to now add in license, author and copyright against this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I heard back from Legal -- we should use edX LLC
for copyright. As far as licensing, I believe it's correct to leave the docs at cc-by-sa-4, because docs.edx.org uses that in its footer. I'll check in with legal on that asynchronously, though. (It's probably not correct to have the repo licensed as AGPL or Apache but the published docs as CC, but that's probably going to be a longer conversation...)
c8215e6
to
e0689b4
Compare
Hey @timmc-edx, I have updated this PR. Can you please give it a look and see if it's good to be merged? |
I'm still seeing Axim listed rather than edX in at least one place. Good question on the logo, but I don't actually know... |
0a87e51
to
ed51eb0
Compare
Hey @timmc-edx, confirmed with @dianakhuang we shall be handling logo in a separate issue. |
This PR deprecates the
edx-sphimx-theme
and replaces it withsphinx-book-theme
Issue Link: #339