Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate edx-sphinx-theme #763

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Aug 7, 2024

This PR deprecates the edx-sphimx-theme and replaces it with sphinx-book-theme
Issue Link: #339

docs/conf.py Outdated
href="https://openedx.org"
property="cc:attributionName"
rel="cc:attributionURL"
>Axim Collaborative</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this appropriate for edx-arch-experiments?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same question for license)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @timmc-edx, you are absolutely right about the Author, license and copyright information. Can I please have the exact data that we need to now add in license, author and copyright against this repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I heard back from Legal -- we should use edX LLC for copyright. As far as licensing, I believe it's correct to leave the docs at cc-by-sa-4, because docs.edx.org uses that in its footer. I'll check in with legal on that asynchronously, though. (It's probably not correct to have the repo licensed as AGPL or Apache but the published docs as CC, but that's probably going to be a longer conversation...)

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/deprecate-edx-sphinx-theme branch from c8215e6 to e0689b4 Compare October 28, 2024 06:37
@huniafatima-arbi
Copy link
Member Author

Hey @timmc-edx, I have updated this PR. Can you please give it a look and see if it's good to be merged?
Plus will we updating the logo as well? If yes, can you please help me get that as well.
Thank you

@timmc-edx
Copy link
Member

I'm still seeing Axim listed rather than edX in at least one place.

Good question on the logo, but I don't actually know...

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/deprecate-edx-sphinx-theme branch from 0a87e51 to ed51eb0 Compare October 29, 2024 09:02
@huniafatima-arbi
Copy link
Member Author

I'm still seeing Axim listed rather than edX in at least one place.

Good question on the logo, but I don't actually know...

Hey @timmc-edx, confirmed with @dianakhuang we shall be handling logo in a separate issue.
Other than that can you please look if the PR is good to go?

@UsamaSadiq UsamaSadiq merged commit d347c7c into main Oct 30, 2024
6 checks passed
@UsamaSadiq UsamaSadiq deleted the huniafatima/deprecate-edx-sphinx-theme branch October 30, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants