-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docker-based local work without lms #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution works well on my end!
Dockerfile
Outdated
@@ -0,0 +1,98 @@ | |||
# Docker in this repo is only supported for running tests locally | |||
# as an alternative to virtualenv natively - johnnagro 2022-02-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update date?
18d0ac1
to
ff8bf8d
Compare
Makefile
Outdated
@@ -105,3 +105,8 @@ dummy_translations: ## generate dummy translation (.po) files | |||
build_dummy_translations: extract_translations dummy_translations compile_translations ## generate and compile dummy translation files | |||
|
|||
validate_translations: build_dummy_translations detect_changed_source_translations ## validate translations | |||
|
|||
## Docker in this repo is only supported for running tests locally | |||
## as an alternative to virtualenv natively - johnnagro 2022-02-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another date to update
docker-compose.yml
Outdated
@@ -0,0 +1,24 @@ | |||
# Docker in this repo is only supported for running tests locally | |||
# as an alternative to virtualenv natively - johnnagro 2022-02-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another date to update
ff8bf8d
to
5a71dbc
Compare
TLDR
Adds a
make test-shell
which launches a dockerized version of the local dev environment - rather than using a local virtualenv.Description
~ Working from openedx/edx-enterprise#1467 ~
There are sometimes benefits and conveniences to having a containerized local environment versus setting up and maintaining python, virtualenv, and system dependencies (mysql-dev, etc) natively. Sometimes installing your code into the LMS container extends your testing cycle past your patience. Here is some docker/makefile config to enable make test-shell to launch a containerized environment containing your local development code so you can make test / make upgrade / 'profit' / etc inside a container.
Action!
pytest
make validate