forked from xapi-project/xen-api
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Test for absence of select: introduce open_1024 in tests
We'll check statically that we are not using Unix.select, but it is good to have a runtime check too, in case some library (C or OCaml) indirectly uses it. Open 1024 file descriptors at the beginning of the test, so that we would hit an exception on the first use of Unix.select with any newly created file descriptor as their value would be >1024 (the limit in `select`). Unconditionally call these in the stdext-unix, quicktest, and xapi tests. Set the default ulimit in 'make test' to 2048. If you are running tests with `dune runtest` directly then you might need to raise this limit, if your shell has a lower limit by default. If needed we could add a better error message or a check for ulimit before attempting to open the 1024 files. No functional change for the product. Signed-off-by: Edwin Török <[email protected]>
- Loading branch information
1 parent
00ec519
commit 3cfff61
Showing
6 changed files
with
33 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters