forked from xapi-project/xen-api
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CA-380551: bump minimum HA SR size to 4GiB
Commit 00cb7f2 changed the default (recommended) size of the redo log to 4GiB, while keeping the minimum at 256MiB for backwards compatibility with existing VDIs. However: * HA must be disabled/re-enabled across updates anyway so backwards compatibility is not needed * the redo-log on its own is known not to work (bug), keeping backwards compatibility here is not useful * it makes it more difficult for XenCenter to tell the user when they chose an SR that is too small If the SR is greater than minimum but below recommended then from the CLI you could still enable HA and create a redo log of the appropriate size, but not from XenCenter (where the size cannot be chosen). We could expose a new RO pool field with the minimum size and update clients to use that, but that is unnecessary complication for a very rare use case. Revert the 'recommended_size' introduction, and instead bump the minimum size. The existing 'SR.assert_can_host_statefile' can then report an error when the size is wrong and XenCenter can appropriately grey out the choice for the user with the correct message. (And this method works also for other reasons why we might reject an SR). Fixes: 00cb7f2 ("redo-log: bump default size to 4GiB") Signed-off-by: Edwin Török <[email protected]>
- Loading branch information
1 parent
9fce1a2
commit 39a012b
Showing
5 changed files
with
5 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters