CP-47536: drop Unix.select in newcli

This is a followup of this commit: 14fd0c9 ("CA-226177: Fix premature termination of cli") That commit dropped the active monitoring of stunnel processes, but kept the while-select loop. That loop serves no purpose now, we can instead do a blocking Unix.read directly, and get woken up when a packet arrives (this is the the single-threaded CLI, not the CLI server). Signed-off-by: Edwin Török <[email protected]>
edwintorok · May 13, 2024 · 31ba3d4 · 31ba3d4
1 parent 76b477e
commit 31ba3d4
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/ocaml/xe-cli/newcli.ml b/ocaml/xe-cli/newcli.ml
@@ -463,14 +463,6 @@ let main_loop ifd ofd permitted_filenames =
   marshal_protocol ofd ;
   let exit_code = ref None in
   while !exit_code = None do
-    (* Wait for input asynchronously so that we can check the status
-       of Stunnel every now and then, for better debug/dignosis.
-    *)
-    while
-      match Unix.select [ifd] [] [] 5.0 with _ :: _, _, _ -> false | _ -> true
-    do
-      ()
-    done ;
     let cmd = try unmarshal ifd with e -> handle_unmarshal_failure e ifd in
     debug "Read: %s\n%!" (string_of_message cmd) ;
     flush stderr ;